{"id":26562,"date":"2015-01-11T11:40:08","date_gmt":"2015-01-11T02:40:08","guid":{"rendered":"http:\/\/www.softantenna.com\/wp\/?p=26562"},"modified":"2015-01-11T11:40:08","modified_gmt":"2015-01-11T02:40:08","slug":"code-review-checklist","status":"publish","type":"post","link":"https:\/\/softantenna.com\/blog\/code-review-checklist\/","title":{"rendered":"\u30b3\u30fc\u30c9\u30ec\u30d3\u30e5\u30fc\u6642\u306b\u5229\u7528\u3057\u305f\u3044\u300cCode Review Checklist\u300d"},"content":{"rendered":"<p><img decoding=\"async\" src=\"https:\/\/softantenna.com\/blog\/wp-content\/uploads\/2015\/01\/Iyes-238381_640.jpg\" alt=\"Yes 238381 640\" title=\"yes-238381_640.jpg\" border=\"0\" width=\"546\" height=\"413\" \/><\/p>\n<p>\u30b3\u30fc\u30c9\u30ec\u30d3\u30e5\u30fc\u3068\u306f\u3001\u30bd\u30d5\u30c8\u30a6\u30a7\u30a2\u306e\u8aa4\u308a\u3092\u4fee\u6b63\u3059\u308b\u305f\u3081\u306b\u884c\u3046\u30bd\u30fc\u30b9\u30b3\u30fc\u30c9\u306e\u8a73\u7d30\u306a\u691c\u67fb\u306e\u3053\u3068\u3002\u30bd\u30d5\u30c8\u30a6\u30a7\u30a2\u958b\u767a\u30d7\u30ed\u30bb\u30b9\u306e\u4e00\u8cab\u3068\u3057\u3057\u3066\u53d6\u308a\u5165\u308c\u3066\u3044\u308b\u958b\u767a\u30c1\u30fc\u30e0\u591a\u3044\u304b\u3082\u3057\u308c\u307e\u305b\u3093\u3002\u3053\u306e\u30b3\u30fc\u30c9\u30ec\u30d3\u30e5\u30fc\u3092\u6709\u52b9\u306b\u884c\u3046\u305f\u3081\u306e\u30c1\u30a7\u30c3\u30af\u9805\u76ee\u300c<a href=\"http:\/\/blog.fogcreek.com\/increase-defect-detection-with-our-code-review-checklist-example\/\">Code Review Checklist<\/a>\u300d\u304c\u516c\u958b\u3055\u308c\u3066\u3044\u307e\u3059(<a href=\"http:\/\/www.reddit.com\/r\/programming\/comments\/2rund4\/code_review_checklist\/\">Reddit<\/a>\u3001<a href=\"https:\/\/news.ycombinator.com\/item?id=8861935\">Hacker News<\/a>)\u3002<\/p>\n<p><!--more--><\/p>\n<h3>\u30c1\u30a7\u30c3\u30af\u30ea\u30b9\u30c8\u3068\u306f\uff1f<\/h3>\n<p>\u63b2\u8f09\u3055\u308c\u3066\u3044\u308b\u30c1\u30a7\u30c3\u30af\u30ea\u30b9\u30c8\u306f\u3001\u30d7\u30ed\u30b0\u30e9\u30de\u30fc\u304c\u9593\u9055\u3048\u3084\u3059\u3044\u4e00\u822c\u7684\u306a\u9593\u9055\u3048\u3092\u898b\u3064\u3051\u51fa\u3059\u305f\u3081\u306e\u3082\u306e\u3068\u3055\u308c\u3001\u4e00\u822c\u3001\u30bb\u30ad\u30e5\u30ea\u30c6\u30a3\u3001\u30c9\u30ad\u30e5\u30e1\u30f3\u30c8\u3001\u30c6\u30b9\u30c8\u306a\u3069\u306e\u5404\u30ab\u30c6\u30b4\u30ea\u304b\u3089\u6570\u500b\u305a\u3064\u30c1\u30a7\u30c3\u30af\u9805\u76ee\u304c\u30d4\u30c3\u30af\u30a2\u30c3\u30d7\u3055\u308c\u3066\u3044\u307e\u3059\u3002\u4f8b\u3048\u3070\u4e00\u822c(General)\u30ab\u30c6\u30b4\u30ea\u306e\u9805\u76ee\u306f\u4ee5\u4e0b\u306e\u901a\u308a\u3068\u306a\u3063\u3066\u3044\u307e\u3059\u3002<\/p>\n<blockquote>\n<ul>\n<li>Does the code work? Does it perform its intended function, the logic is correct etc.<\/li>\n<li>Is all the code easily understood?<\/li>\n<li>Does it conform to your agreed coding conventions? These will usually cover location of braces, variable and function names, line length, indentations, formatting, and comments.<\/li>\n<li>Is there any redundant or duplicate code?<\/li>\n<li>Is the code as modular as possible?<\/li>\n<li>Can any global variables be replaced?<\/li>\n<li>Is there any commented out code?<\/li>\n<li>Do loops have a set length and correct termination conditions?<\/li>\n<li>Can any of the code be replaced with library functions?<\/li>\n<li>Can any logging or debugging code be removed?<\/li>\n<\/ul>\n<\/blockquote>\n<p>\u300c\u30b3\u30fc\u30c9\u306f\u304d\u3061\u3093\u3068\u52d5\u4f5c\u3059\u308b\u304b\uff1f\u300d\u3001\u300c\u5168\u3066\u306e\u30b3\u30fc\u30c9\u304c\u7c21\u5358\u306b\u7406\u89e3\u3067\u304d\u308b\u304b\u300d\u3001\u300c\u30b3\u30fc\u30c7\u30a3\u30f3\u30b0\u57fa\u6e96\u3092\u6e80\u305f\u3057\u3066\u3044\u308b\u304b\u300d\u306a\u3069\u306e\u9805\u76ee\u304c\u53d6\u308a\u4e0a\u3052\u3089\u308c\u3066\u3044\u307e\u3059\u3002<\/p>\n<h3>\u307e\u3068\u3081<\/h3>\n<p>\u3053\u306e\u30c1\u30a7\u30c3\u30af\u30ea\u30b9\u30c8\u306f\u3042\u304f\u307e\u3067\u30b9\u30bf\u30fc\u30c8\u30dd\u30a4\u30f3\u30c8\u3067\u3001\u3053\u306e\u30ea\u30b9\u30c8\u3092\u3082\u3068\u306b\u30ab\u30b9\u30bf\u30de\u30a4\u30ba\u3057\u3066\u6700\u9069\u5316\u3059\u308b\u3053\u3068\u304c\u671b\u307e\u3057\u3044\u3068\u3055\u308c\u3066\u3044\u307e\u3059\u3002\u81ea\u4f5c\u306e\u30c1\u30a7\u30c3\u30af\u9805\u76ee\u3092\u4f5c\u6210\u3059\u308b\u3068\u304d\u306e\u6307\u91dd(Yes\/No\u3067\u7b54\u3048\u3084\u3059\u3044\u3082\u306e\u306a\u3069)\u3082\u63b2\u8f09\u3055\u308c\u3066\u3044\u308b\u306e\u3067\u3001\u8a73\u7d30\u306f\u540c\u30b5\u30a4\u30c8\u3067\u78ba\u8a8d\u3057\u3066\u304f\u3060\u3055\u3044\u3002\u3069\u306e\u3088\u3046\u306a\u30c1\u30a7\u30c3\u30af\u304c\u671b\u307e\u3057\u3044\u304b<a href=\"http:\/\/www.reddit.com\/r\/programming\/comments\/2rund4\/code_review_checklist\/\">Reddit<\/a>\u3084<a href=\"https:\/\/news.ycombinator.com\/item?id=8861935\">Hacker News<\/a>\u3067\u610f\u898b\u304c\u4ea4\u63db\u3055\u308c\u3066\u3044\u3066\u3053\u3061\u3089\u3082\u53c2\u8003\u306b\u306a\u308b\u3067\u3057\u3087\u3046\u3002<\/p>\n<p>\u30b3\u30fc\u30c9\u30ec\u30d3\u30e5\u30fc\u306f\u5927\u5909\u6709\u7528\u3067\u3059\u304c\u3001\u30ec\u30d3\u30e5\u30a2\u30fc\u306b\u3088\u3063\u3066\u57fa\u6e96\u304c\u7570\u306a\u308b\u3068\u52b9\u679c\u304c\u6e1b\u5c11\u3059\u308b\u304a\u305d\u308c\u3082\u3042\u308a\u307e\u3059\u3002\u30c1\u30a7\u30c3\u30af\u30ea\u30b9\u30c8\u3092\u6709\u52b9\u306b\u4f7f\u3063\u3066\u9ad8\u54c1\u8cea\u30bd\u30d5\u30c8\u30a6\u30a7\u30a2\u3092\u30d0\u30ea\u30d0\u30ea\u4f5c\u3063\u3066\u3044\u304d\u305f\u3044\u3082\u306e\u3067\u3059\u3002<\/p>\n","protected":false},"excerpt":{"rendered":"<p>\u30b3\u30fc\u30c9\u30ec\u30d3\u30e5\u30fc\u3068\u306f\u3001\u30bd\u30d5\u30c8\u30a6\u30a7\u30a2\u306e\u8aa4\u308a\u3092\u4fee\u6b63\u3059\u308b\u305f\u3081\u306b\u884c\u3046\u30bd\u30fc\u30b9\u30b3\u30fc\u30c9\u306e\u8a73\u7d30\u306a\u691c\u67fb\u306e\u3053\u3068\u3002\u30bd\u30d5\u30c8\u30a6\u30a7\u30a2\u958b\u767a\u30d7\u30ed\u30bb\u30b9\u306e\u4e00\u8cab\u3068\u3057\u3057\u3066\u53d6\u308a\u5165\u308c\u3066\u3044\u308b\u958b\u767a\u30c1\u30fc\u30e0\u591a\u3044\u304b\u3082\u3057\u308c\u307e\u305b\u3093\u3002\u3053\u306e\u30b3\u30fc\u30c9\u30ec\u30d3\u30e5\u30fc\u3092\u6709\u52b9\u306b\u884c\u3046\u305f\u3081\u306e\u30c1\u30a7\u30c3\u30af\u9805\u76ee [&hellip;]<\/p>\n","protected":false},"author":2,"featured_media":26561,"comment_status":"open","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"swell_btn_cv_data":"","footnotes":""},"categories":[75],"tags":[2907],"class_list":["post-26562","post","type-post","status-publish","format-standard","has-post-thumbnail","hentry","category-software","tag-codereview"],"_links":{"self":[{"href":"https:\/\/softantenna.com\/blog\/wp-json\/wp\/v2\/posts\/26562","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/softantenna.com\/blog\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/softantenna.com\/blog\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/softantenna.com\/blog\/wp-json\/wp\/v2\/users\/2"}],"replies":[{"embeddable":true,"href":"https:\/\/softantenna.com\/blog\/wp-json\/wp\/v2\/comments?post=26562"}],"version-history":[{"count":0,"href":"https:\/\/softantenna.com\/blog\/wp-json\/wp\/v2\/posts\/26562\/revisions"}],"wp:featuredmedia":[{"embeddable":true,"href":"https:\/\/softantenna.com\/blog\/wp-json\/wp\/v2\/media\/26561"}],"wp:attachment":[{"href":"https:\/\/softantenna.com\/blog\/wp-json\/wp\/v2\/media?parent=26562"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/softantenna.com\/blog\/wp-json\/wp\/v2\/categories?post=26562"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/softantenna.com\/blog\/wp-json\/wp\/v2\/tags?post=26562"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}